Re: [parallel query] random server crash while running tpc-h query on power2 - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [parallel query] random server crash while running tpc-h query on power2
Date
Msg-id CA+Tgmob9dabioB=nK=0p38ynar1byshimYjmzoLVrboc0+Wt=Q@mail.gmail.com
Whole thread Raw
In response to Re: [parallel query] random server crash while running tpc-h query on power2  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [parallel query] random server crash while running tpc-h query on power2  (Rushabh Lathia <rushabh.lathia@gmail.com>)
List pgsql-hackers
On Sat, Aug 13, 2016 at 4:36 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> AFAICS, your patch seems to be the right fix for this issue, unless we
> need the instrumentation information during execution (other than for
> explain) for some purpose.

Hmm, I disagree.  It should be the job of
ExecParallelRetrieveInstrumentation to allocate its data in the
correct context, not the responsibility of nodeGather.c to work around
the fact that it doesn't.  The worker instrumentation should be
allocated in the same context as the regular instrumentation
information, which I assume is probably the per-query context.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables)
Next
From: Shay Rojansky
Date:
Subject: Re: Slowness of extended protocol