Re: Rethinking plpgsql's assignment implementation - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Rethinking plpgsql's assignment implementation
Date
Msg-id CAFj8pRDgF9TFumQLHXp1TbNrdG9OjS_OpVb40XyZZER3-E5SYA@mail.gmail.com
Whole thread Raw
In response to Re: Rethinking plpgsql's assignment implementation  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: Rethinking plpgsql's assignment implementation
List pgsql-hackers


so 26. 12. 2020 v 19:00 odesílatel Pavel Stehule <pavel.stehule@gmail.com> napsal:
Hi

I repeated tests. I wrote a set of simple functions. It is a synthetical test, but I think it can identify potential problems well.

I calculated the average of 3 cycles and I checked the performance of each function. I didn't find any problem. The total execution time is well too. Patched code is about 11% faster than master (14sec x 15.8sec). So there is new important functionality with nice performance benefits.

make check-world passed

I played with plpgsql_check tests and again I didn't find any significant issue of this patch. I am very satisfied with implementation.

Now, the behavior of  SELECT INTO is behind the assign statement and this fact should be documented. Usually we don't need to use array's fields here, but somebody can try it.

Regards

Pavel



Regards

Pavel



pgsql-hackers by date:

Previous
From: Eric Hanson
Date:
Subject: Re: Feature request: Connection string parsing for postgres_fdw
Next
From: Tom Lane
Date:
Subject: Re: Rethinking plpgsql's assignment implementation