Re: Showing parallel status in \df+ - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Showing parallel status in \df+
Date
Msg-id CAFj8pRBmBJBJ5nMPBHMQJg=UPeroeONmY=z+qNuuey87a59G+A@mail.gmail.com
Whole thread Raw
In response to Re: Showing parallel status in \df+  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Showing parallel status in \df+  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers


2016-08-22 18:19 GMT+02:00 Robert Haas <robertmhaas@gmail.com>:
On Mon, Aug 22, 2016 at 4:49 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
> This feature shows source code for PL function when \df statement was used.
> I am not too sure, if this functionality is necessary - but I don't see any
> argument against. Sometimes it can be useful, mainly when we work with
> overloaded functions.

Wait, really?  I thought Peter was complaining about the fact that it
*removed* that from the display.

He also complained about the fact that the subject line of this thread
and what the patch actually does have diverged considerably, which I
think is a fair complaint.

If I understand to purpose of this patch - it is compromise - PL source is removed from table, but it is printed in result.

I am sure so there are low benefit from displaying the body of PL function inside table. But I see some benefit on Tom's design. We cannot to simply show source code of more functions. \sf doesn't support it. The source is displayed on the end, so there is low impact on result.

Regards

Pavel


 

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Re: PROPOSAL: make PostgreSQL sanitizers-friendly (and prevent information disclosure)
Next
From: Robert Haas
Date:
Subject: Re: New SQL counter statistics view (pg_stat_sql)