Postgres Pro
Downloads
Home   >   mailing lists

Re: [RM2579][pgAdmin4] Set default file listing layout as listinstead of grid - Mailing list pgadmin-hackers

From Harshal Dhumal
Subject Re: [RM2579][pgAdmin4] Set default file listing layout as listinstead of grid
Date
Msg-id CAFiP3vw0md6UC-3dytEhL=m7rGJVK66a2gjqyH6ta+aKH_NgEw@mail.gmail.com
Whole thread Raw
In response to Re: [RM2579][pgAdmin4] Set default file listing layout as listinstead of grid  (Dave Page <dpage@pgadmin.org>)
Responses Re: [RM2579][pgAdmin4] Set default file listing layout as listinstead of grid
List pgadmin-hackers
Tree view
Hi,

On Mon, Jul 24, 2017 at 4:23 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

Please find attached patch to set default layout of file listing as a list in file manager.
Also replaced alertify with out custom alertifywrapper in file manager utils.js

This isn't a bad idea on the face of it, but there are some things to fix/consider:

- The HTML file seems to be missing translation markers. Can you add them throughout please?
- We should save the users preference in the config database.
- The grid view seems to underline the file size and for no apparent reason change the mouse cursor to ? on mouseover. Let's change the text style to be consistent and get rid of the mouseover.
Please find updated patch
 

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Update keyboard shortcuts per discussion. Also,make