Postgres Pro
Downloads
Home   >   mailing lists

Re: [RM2579][pgAdmin4] Set default file listing layout as listinstead of grid - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [RM2579][pgAdmin4] Set default file listing layout as listinstead of grid
Date
Msg-id CA+OCxows56jVtkaaEGWHZoh_psFoyfiPTcehe5mOf5+KiKs56A@mail.gmail.com
Whole thread Raw
In response to [RM2579][pgAdmin4] Set default file listing layout as list instead of grid  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
Responses Re: [RM2579][pgAdmin4] Set default file listing layout as listinstead of grid  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi

On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

Please find attached patch to set default layout of file listing as a list in file manager.
Also replaced alertify with out custom alertifywrapper in file manager utils.js

This isn't a bad idea on the face of it, but there are some things to fix/consider:

- The HTML file seems to be missing translation markers. Can you add them throughout please?
- We should save the users preference in the config database.
- The grid view seems to underline the file size and for no apparent reason change the mouse cursor to ? on mouseover. Let's change the text style to be consistent and get rid of the mouseover.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers][patch]
Next
From: pgAdmin 4 Jenkins
Date:
Subject: Jenkins build is back to normal : pgadmin4-master-python36 #257