Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor
Date
Msg-id CAKKotZSti-1g4w6_xDKkBeF7L+76mvCDeV27Sv076p0qAwqDAA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor  (Robert Eckhardt <reckhardt@pivotal.io>)
Responses Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor
List pgadmin-hackers
Hi Dave,

Please find updated patch for new shortcut keys, I have tested it on all three major platforms (macOS, Linux & Windows with Chrome, FF & IE11 Browsers).

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Jul 21, 2017 at 9:38 PM, Robert Eckhardt <reckhardt@pivotal.io> wrote:
Right - we lose the ability to uncomment multiple levels though, which may also be useful.

Well yes. 

I would argue that simplicity trumps potential use. I'd also argue that attempting to maintain consistency across environments (IDEs, etc. ) is advantageous. This was the philosophy we were going with when enabling excel like behavior (also why I'm not fully happy with how it is today). 

-- Rob

Attachment

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: [pgAdmin4][Patch]: Backform control visibility fix
Next
From: Harshal Dhumal
Date:
Subject: Re: [RM2579][pgAdmin4] Set default file listing layout as listinstead of grid