Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor
Date
Msg-id CA+OCxozV5S00TP02PvwvJrnEE4_jkwCgPfbXz2RV6dripJBFqw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor  (Shirley Wang <swang@pivotal.io>)
List pgadmin-hackers
Tree view
Thanks, applied. I also extended the code you added to ensure the labels for the Find/Replace options are now platform-correct.

On Wed, Jul 26, 2017 at 10:29 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

Please find updated patch for new shortcut keys, I have tested it on all three major platforms (macOS, Linux & Windows with Chrome, FF & IE11 Browsers).

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 21, 2017 at 9:38 PM, Robert Eckhardt <reckhardt@pivotal.io> wrote:
Right - we lose the ability to uncomment multiple levels though, which may also be useful.

Well yes. 

I would argue that simplicity trumps potential use. I'd also argue that attempting to maintain consistency across environments (IDEs, etc. ) is advantageous. This was the philosophy we were going with when enabling excel like behavior (also why I'm not fully happy with how it is today). 

-- Rob




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Update keyboard shortcuts per discussion. Also,make
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Handle control visibility properly in javascriptstri