Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED - Mailing list pgsql-hackers

On Wed, Aug 20, 2014 at 12:35 PM, Thom Brown <thom@linux.com> wrote:
>
> Hi Fabrizio,
>
> +      This form changes the table persistence type from unlogged to permanent or
> +      from unlogged to permanent (see <xref linkend="SQL-CREATETABLE-UNLOGGED">).
>
> Shouldn't this read "unlogged to permanent or from permanent to unlogged"?
>

Fixed.

> "ERROR:  table test is not permanent"
>
> Perhaps this would be better as "table test is unlogged" as "permanent" doesn't match the term used in the DDL syntax.
>

Fixed.

> Gave the patch a quick test-drive on a replicated instance, and it appears to operate as described.
>

Thanks for your review.

Att,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello