Re: "parallel= " information is not coming in pg_dumpall for create aggregate - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: "parallel= " information is not coming in pg_dumpall for create aggregate
Date
Msg-id CAFcNs+p+C-MZiPBwpUeOLrJEwgdMheyWW_uu_hQN9guBqd3AbA@mail.gmail.com
Whole thread Raw
In response to Re: "parallel= " information is not coming in pg_dumpall for create aggregate  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Apr 21, 2016 at 12:06 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Mon, Apr 18, 2016 at 10:47 AM, Fabrízio de Royes Mello
> <fabriziomello@gmail.com> wrote:
> >> I checked in PG 9.6 , if we create an aggregate function with saying -
> >> parallel=safe/restricted/unsafe and then take
> >> a pg_dumpall of the entire cluster , "parallel= " is missing from create
> >> aggregate syntax
> >>
> >> Steps to reproduce -
> >>
> >> .)connect to psql terminal and create an aggregate function
> >>
> >> postgres=# CREATE AGGREGATE unsafe_sum100 (float8)
> >> (
> >>     stype = float8,
> >>     sfunc = float8pl,
> >>     mstype = float8,
> >>     msfunc = float8pl,
> >>     minvfunc = float8mi,
> >>     parallel=safe);
> >> CREATE AGGREGATE
> >>
> >> .)perform pg_dumpall against that cluster
> >>
> >> .)check the content of create aggregate unsafe_sum100 in the file
> >>
> >> "
> >> -
> >> -- Name: unsafe_sum100(double precision); Type: AGGREGATE; Schema: public;
> >> Owner: centos
> >> --
> >>
> >> CREATE AGGREGATE unsafe_sum100(double precision) (
> >>     SFUNC = float8pl,
> >>     STYPE = double precision,
> >>     MSFUNC = float8pl,
> >>     MINVFUNC = float8mi,
> >>     MSTYPE = double precision
> >> );
> >>
> >> "
> >
> > You're correct... try the attached patch to fix it.
>
> Nice catch, Tushar.  Thanks for the patch, Fabrízio.  Committed.
>

You're welcome!

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: if (!superuser) checks
Next
From: Kevin Grittner
Date:
Subject: Re: [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()