Re: "parallel= " information is not coming in pg_dumpall for create aggregate - Mailing list pgsql-hackers

From Robert Haas
Subject Re: "parallel= " information is not coming in pg_dumpall for create aggregate
Date
Msg-id CA+TgmoZKSWBsXuNph5evtpNrvN7cgD2Eu6yQ6qOx6OJsJ5O-Ow@mail.gmail.com
Whole thread Raw
In response to Re: "parallel= " information is not coming in pg_dumpall for create aggregate  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
Responses Re: "parallel= " information is not coming in pg_dumpall for create aggregate  (tushar <tushar.ahuja@enterprisedb.com>)
Re: "parallel= " information is not coming in pg_dumpall for create aggregate  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
List pgsql-hackers
On Mon, Apr 18, 2016 at 10:47 AM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
>> I checked in PG 9.6 , if we create an aggregate function with saying -
>> parallel=safe/restricted/unsafe and then take
>> a pg_dumpall of the entire cluster , "parallel= " is missing from create
>> aggregate syntax
>>
>> Steps to reproduce -
>>
>> .)connect to psql terminal and create an aggregate function
>>
>> postgres=# CREATE AGGREGATE unsafe_sum100 (float8)
>> (
>>     stype = float8,
>>     sfunc = float8pl,
>>     mstype = float8,
>>     msfunc = float8pl,
>>     minvfunc = float8mi,
>>     parallel=safe);
>> CREATE AGGREGATE
>>
>> .)perform pg_dumpall against that cluster
>>
>> .)check the content of create aggregate unsafe_sum100 in the file
>>
>> "
>> -
>> -- Name: unsafe_sum100(double precision); Type: AGGREGATE; Schema: public;
>> Owner: centos
>> --
>>
>> CREATE AGGREGATE unsafe_sum100(double precision) (
>>     SFUNC = float8pl,
>>     STYPE = double precision,
>>     MSFUNC = float8pl,
>>     MINVFUNC = float8mi,
>>     MSTYPE = double precision
>> );
>>
>> "
>
> You're correct... try the attached patch to fix it.

Nice catch, Tushar.  Thanks for the patch, Fabrízio.  Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: pg_stat_activity crashes
Next
From: Robert Haas
Date:
Subject: Re: Fix of doc for synchronous_standby_names.