Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as. - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.
Date
Msg-id CAFOhELe8_PWc67j4eWti3HjAb1fbbETmQxjbDdTOxZfdN2UxUw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.  (Amol Vyavahare <amol.vyavahare@enterprisedb.com>)
Responses Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.  (Amol Vyavahare <amol.vyavahare@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Amol,

The patch is working fine and looks good to me however some code related review comments:

1. The test case is particularly written for Temporary table with Commit Drop, so please mention it in the comments.
2. Also, the class TestQueryUpdatableResultset is been inherited, so no need to repeat the same methods, for example: setUp, _execute_select_sql, tearDown


Thanks,
Khushboo


On Fri, Apr 17, 2020 at 3:49 PM Amol Vyavahare <amol.vyavahare@enterprisedb.com> wrote:
Hi Khushboo,

Please find attached the updated patch with the latest changes as suggested along with API test cases for the RM4946 issue fix. 

Thank You.

On Wed, Apr 15, 2020 at 2:26 PM Amol Vyavahare <amol.vyavahare@enterprisedb.com> wrote:
Sure, will do that. 

On Wed, Apr 15, 2020 at 1:33 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Amol,

On Wed, Apr 15, 2020 at 12:06 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

I am reviewing this patch.

Thanks,
Khushboo

On Wed, Apr 15, 2020 at 11:45 AM Amol Vyavahare <amol.vyavahare@enterprisedb.com> wrote:
Hi Hackers,
Attached is the patch to fix the Issue with temporary tables on commit drop as. This patch fixes the issue where an error was thrown when the user tried to create a temporary table via query tool and no result was displayed when the query was executed.

Please review.

Please write the API test cases for the same even if the changes are very small but they are in the SQL Editor backend code. 
The patch is working fine and looks good to me.

Thanks,
Khushboo
--
Regards,
Amol Vyavahare
EnterpriseDB Corporation
The Enterprise Postgres Company
T: +91 20 6644 9600, M: +91 738 738 2128
EDB PostgresUnit 301 A, Third Floor, Godrej Castlemaine,
155, Sassoon Road, Pune, MH - 411001
Blog FeedFacebookTwitterLinkedInGoogle+
EnterpriseDB Blog: http://blogs.enterprisedb.com/





--
Regards,
Amol Vyavahare
EnterpriseDB Corporation
The Enterprise Postgres Company
T: +91 20 6644 9600, M: +91 738 738 2128
EDB PostgresUnit 301 A, Third Floor, Godrej Castlemaine,
155, Sassoon Road, Pune, MH - 411001
Blog FeedFacebookTwitterLinkedInGoogle+
EnterpriseDB Blog: http://blogs.enterprisedb.com/





--
Regards,
Amol Vyavahare
EnterpriseDB Corporation
The Enterprise Postgres Company
T: +91 20 6644 9600, M: +91 738 738 2128
EDB PostgresUnit 301 A, Third Floor, Godrej Castlemaine,
155, Sassoon Road, Pune, MH - 411001
Blog FeedFacebookTwitterLinkedInGoogle+
EnterpriseDB Blog: http://blogs.enterprisedb.com/



pgadmin-hackers by date:

Previous
From: "Libor M."
Date:
Subject: Re: pgAdmin 4 - next gettext usage fixes
Next
From: Khushboo Vashi
Date:
Subject: Re: [pgAdmin][RM5157] Default sort order at start in view table databy primary key by default