Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as. - Mailing list pgadmin-hackers

From Amol Vyavahare
Subject Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.
Date
Msg-id CAF0fJeU72g7+LFPyJDzd02GKWs41kvNK3GbBFPvoMfkFL-_7Sw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.  (Amol Vyavahare <amol.vyavahare@enterprisedb.com>)
Responses Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.
List pgadmin-hackers
Tree view
Hi Khushboo,

Please find attached the updated patch with the latest changes as suggested along with API test cases for the RM4946 issue fix. 

Thank You.

On Wed, Apr 15, 2020 at 2:26 PM Amol Vyavahare <amol.vyavahare@enterprisedb.com> wrote:
Sure, will do that. 

On Wed, Apr 15, 2020 at 1:33 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Amol,

On Wed, Apr 15, 2020 at 12:06 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

I am reviewing this patch.

Thanks,
Khushboo

On Wed, Apr 15, 2020 at 11:45 AM Amol Vyavahare <amol.vyavahare@enterprisedb.com> wrote:
Hi Hackers,
Attached is the patch to fix the Issue with temporary tables on commit drop as. This patch fixes the issue where an error was thrown when the user tried to create a temporary table via query tool and no result was displayed when the query was executed.

Please review.

Please write the API test cases for the same even if the changes are very small but they are in the SQL Editor backend code. 
The patch is working fine and looks good to me.

Thanks,
Khushboo
--
Regards,
Amol Vyavahare
EnterpriseDB Corporation
The Enterprise Postgres Company
T: +91 20 6644 9600, M: +91 738 738 2128
EDB PostgresUnit 301 A, Third Floor, Godrej Castlemaine,
155, Sassoon Road, Pune, MH - 411001
Blog FeedFacebookTwitterLinkedInGoogle+
EnterpriseDB Blog: http://blogs.enterprisedb.com/





--
Regards,
Amol Vyavahare
EnterpriseDB Corporation
The Enterprise Postgres Company
T: +91 20 6644 9600, M: +91 738 738 2128
EDB PostgresUnit 301 A, Third Floor, Godrej Castlemaine,
155, Sassoon Road, Pune, MH - 411001
Blog FeedFacebookTwitterLinkedInGoogle+
EnterpriseDB Blog: http://blogs.enterprisedb.com/





--
Regards,
Amol Vyavahare
EnterpriseDB Corporation
The Enterprise Postgres Company
T: +91 20 6644 9600, M: +91 738 738 2128
EDB PostgresUnit 301 A, Third Floor, Godrej Castlemaine,
155, Sassoon Road, Pune, MH - 411001
Blog FeedFacebookTwitterLinkedInGoogle+
EnterpriseDB Blog: http://blogs.enterprisedb.com/



Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][RM#3495] Do not check for binary content if BOM markeris present in the file
Next
From: Nagesh Dhope
Date:
Subject: Re: [pgAdmin][RM4573] Download csv as .csv when delimeter set comma(,)