TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity - Mailing list pgsql-hackers

From Thomas Munro
Subject TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity
Date
Msg-id CAEepm=0NvOGZ8B6GbQyQe2C_c2m3LKJ9w=8OMBaYRLgZ_Gw6Nw@mail.gmail.com
Whole thread Raw
Responses Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity  (Vik Fearing <vik.fearing@2ndquadrant.com>)
Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi hackers,

Andrew Gierth complained off-list that TupleDescCopy() doesn't clear
atthasdef.  Yeah, that's an oversight.  The function is new in commit
cc5f81366c36 and was written by me to support "flat" (pointer-free)
tuple descriptors for use in DSM.  Following the example of
CreateTupleDescCopy() I think it should also clear attnotnull and
attidentity.  Please see attached.

-- 
Thomas Munro
http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] A design for amcheck heapam verification
Next
From: Andres Freund
Date:
Subject: Expression based grouping equality implementation