Re: predefined role(s) for VACUUM and ANALYZE - Mailing list pgsql-hackers

From Corey Huinker
Subject Re: predefined role(s) for VACUUM and ANALYZE
Date
Msg-id CADkLM=fg15_SYRGBcTFpoW-vVUTCkLfe+NTM0G32RjWY1W5Pvw@mail.gmail.com
Whole thread Raw
In response to Re: predefined role(s) for VACUUM and ANALYZE  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: predefined role(s) for VACUUM and ANALYZE  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Sounds good.  Here's a new patch set with aclitem's typalign fixed.

Patch applies.
Passes make check and make check-world.
Test coverage seems adequate.

Coding is very clear and very much in the style of the existing code. Any quibbles I have with the coding style are ones I have with the overall pg-style, and this isn't the forum for that.

I haven't done any benchmarking yet, but it seems that the main question will be the impact on ordinary DML statements.

I have no opinion about the design debate earlier in this thread, but I do think that this patch is ready and adds something concrete to the ongoing discussion.

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Refactor to introduce pg_strcoll().
Next
From: Tatsuo Ishii
Date:
Subject: Re: make_ctags: use -I option to ignore pg_node_attr macro