Re: predefined role(s) for VACUUM and ANALYZE - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: predefined role(s) for VACUUM and ANALYZE
Date
Msg-id 20220930231834.GA366260@nathanxps13
Whole thread Raw
In response to Re: predefined role(s) for VACUUM and ANALYZE  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: predefined role(s) for VACUUM and ANALYZE
List pgsql-hackers
On Fri, Sep 30, 2022 at 07:05:38PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> On Fri, Sep 30, 2022 at 06:00:53PM -0400, Tom Lane wrote:
>>> ... and now requires double alignment ... did you fix its typalign?
> 
>> Nope, I missed that, thanks for pointing it out.  Should we move ai_privs
>> to the beginning of the struct, too?
> 
> Don't see any point, there won't be any padding.  If we ever change the
> sizeof(Oid), or add more fields, we can consider what to do then.

Sounds good.  Here's a new patch set with aclitem's typalign fixed.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Lukas Fittl
Date:
Subject: Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)
Next
From: Andres Freund
Date:
Subject: Re: problems with making relfilenodes 56-bits