Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] replication_slot_catalog_xmin not explicitlyinitialized when creating procArray - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: [HACKERS] replication_slot_catalog_xmin not explicitlyinitialized when creating procArray
Date
Msg-id CAD21AoBjsyxUKpkBWaePnHKzPHQNKGrw3eE2TAm6-_su_vHTcw@mail.gmail.com
Whole thread Raw
In response to [HACKERS] replication_slot_catalog_xmin not explicitly initialized whencreating procArray  ("Wong, Yi Wen" <yiwong@amazon.com>)
Responses Re: [HACKERS] replication_slot_catalog_xmin not explicitlyinitialized when creating procArray
List pgsql-hackers
Tree view 
On Sat, Jul 8, 2017 at 2:19 AM, Wong, Yi Wen <yiwong@amazon.com> wrote:
> Hi,
>
>
> replication_slot_catalog_xmin is not explictly initialized to
> InvalidTransactionId.
>
>
> Normally, there isn't an issue with this because a freshly mmap'd memory is
> zeroed, and the value of InvalidTransactionId is 0.
>
> If the memory was not 0 for whatever reason, VACUUM would not behave as
> expected.
>
>
> See attached patch.
>

Thank you for the patch. This change makes sense to me.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Authentification method on client side checking
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode