[HACKERS] replication_slot_catalog_xmin not explicitly initialized whencreating procArray - Mailing list pgsql-hackers

From Wong, Yi Wen
Subject [HACKERS] replication_slot_catalog_xmin not explicitly initialized whencreating procArray
Date
Msg-id 1499447984689.7466@amazon.com
Whole thread Raw
Responses Re: [HACKERS] replication_slot_catalog_xmin not explicitlyinitialized when creating procArray
List pgsql-hackers

Hi,


replication_slot_catalog_xmin is not explictly initialized to InvalidTransactionId.


Normally, there isn't an issue with this because a freshly mmap'd memory is zeroed, and the value of InvalidTransactionId is 0.

If the memory was not 0 for whatever reason, VACUUM would not behave as expected.


See attached patch.


Thanks,

Yi Wen

Attachment

pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: [HACKERS] SCRAM auth and Pgpool-II
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] [WIP] Zipfian distribution in pgbench