Postgres Pro
Downloads
Home   >   mailing lists

Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
Date
Msg-id CAD21AoAd+SC=G_CC_=QdvVdeqjHGs1SgeQPU5vB4CYhrgd5QYQ@mail.gmail.com
Whole thread Raw
In response to Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
List pgsql-hackers
Tree view 
On Wed, Jun 14, 2023 at 4:47 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Jun 14, 2023 at 03:38:10PM +0800, Richard Guo wrote:
> > +1.  BTW, it seems that GUC_UNIT_TIME is not used anywhere except in
> > GUC_UNIT.  I was wondering if we can retire it, but maybe we'd better
> > not.  It still indicates that we need to use time units table.
>
> Some out-of-core code declaring custom GUCs could rely on that, so
> it is better not to remove it.

+1 not to remove it.

I've attached the patch to fix  (GUC_UNIT_MEMORY | GUC_UNIT_TIME)
thing, and am going to push it later today to only master branch.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
Attachment

pgsql-hackers by date:

Previous
From: Vladimir Churyukin
Date:
Subject: Re: Bypassing shared_buffers
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Shouldn't cost_append() also scale the partial path's cost?