Postgres Pro
Downloads
Home   >   mailing lists

Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
Date
Msg-id ZIlwod7WjAs3SM/n@paquier.xyz
Whole thread Raw
In response to Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
List pgsql-hackers
Tree view 
On Wed, Jun 14, 2023 at 03:38:10PM +0800, Richard Guo wrote:
> +1.  BTW, it seems that GUC_UNIT_TIME is not used anywhere except in
> GUC_UNIT.  I was wondering if we can retire it, but maybe we'd better
> not.  It still indicates that we need to use time units table.

Some out-of-core code declaring custom GUCs could rely on that, so
it is better not to remove it.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
Next
From: "Joel Jacobson"
Date:
Subject: Re: Do we want a hashset type?