Postgres Pro
Downloads
Home   >   mailing lists

Re: Problem with multiple comments - Mailing list pgadmin-support

From Per Wigren
Subject Re: Problem with multiple comments
Date
Msg-id CACjysiXoU6Z6VxBrwpvsPT60L_x3Zk+E9u9ZJ-+=AYSieLTi_g@mail.gmail.com
Whole thread Raw
In response to Re: Problem with multiple comments  (Dave Page <dpage@pgadmin.org>)
Responses Re: Problem with multiple comments  (Dave Page <dpage@pgadmin.org>)
List pgadmin-support
Tree view
Unfortunately I don't have a build environment for this here at work but I can confirm that by manually applying the change to the query in edbPackage.cpp in the diff to the query I snatched from pg_log, the output looks good. No more duplicates.
// Per


2012/12/6 Dave Page <dpage@pgadmin.org>
On Thu, Dec 6, 2012 at 11:48 AM, Magnus Hagander <magnus@hagander.net> wrote:
> Certainly sounds like a very similar problem. If so, the query is
> simply buggy - it's just that a pg_upgrade'd environment is *much*
> more likely to run into the problem than before.
>
> I only checked the usages of pg_shdescription. The same bug might well
> exist with almost all uses of pg_description.

OK, here's a patch that should fix this, as well as Magnus' previous
fix which doesn't appear to have been tested so well :-p

Per; are you able to test this?

Magnus; can you give it at least an eyeball review before I commit
please, in case there are any thinkos in there.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-support by date:

Previous
From: Dave Page
Date:
Subject: Re: Problem with multiple comments
Next
From: Dave Page
Date:
Subject: Re: Problem with multiple comments