Re: Problem with multiple comments - Mailing list pgadmin-support

From Dave Page
Subject Re: Problem with multiple comments
Date
Msg-id CA+OCxox0k1HTwX7Y8=y1faH_LE8OCr4dz9c-6cUSjdaK8WW+FQ@mail.gmail.com
Whole thread Raw
In response to Re: Problem with multiple comments  (Per Wigren <per.wigren@gmail.com>)
List pgadmin-support
Thanks - I've committed and pushed the patch.

On Fri, Dec 7, 2012 at 10:39 AM, Per Wigren <per.wigren@gmail.com> wrote:
> Unfortunately I don't have a build environment for this here at work but I
> can confirm that by manually applying the change to the query in
> edbPackage.cpp in the diff to the query I snatched from pg_log, the output
> looks good. No more duplicates.
> // Per
>
>
> 2012/12/6 Dave Page <dpage@pgadmin.org>
>>
>> On Thu, Dec 6, 2012 at 11:48 AM, Magnus Hagander <magnus@hagander.net>
>> wrote:
>> > Certainly sounds like a very similar problem. If so, the query is
>> > simply buggy - it's just that a pg_upgrade'd environment is *much*
>> > more likely to run into the problem than before.
>> >
>> > I only checked the usages of pg_shdescription. The same bug might well
>> > exist with almost all uses of pg_description.
>>
>> OK, here's a patch that should fix this, as well as Magnus' previous
>> fix which doesn't appear to have been tested so well :-p
>>
>> Per; are you able to test this?
>>
>> Magnus; can you give it at least an eyeball review before I commit
>> please, in case there are any thinkos in there.
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgadmin-support by date:

Previous
From: Per Wigren
Date:
Subject: Re: Problem with multiple comments
Next
From: Magnus Hagander
Date:
Subject: Re: Problem with multiple comments