wrong comments in rewriteTargetListIU - Mailing list pgsql-hackers

From jian he
Subject wrong comments in rewriteTargetListIU
Date
Msg-id CACJufxFMBe0nPXOQZMLTH4Ry5Gyj4m+2Z05mRi9KB4hk8rGt9w@mail.gmail.com
Whole thread Raw
Responses Re: wrong comments in rewriteTargetListIU
List pgsql-hackers
hi.

in function, rewriteTargetListIU
we have:

for (attrno = 1; attrno <= numattrs; attrno++)
{
            /*
             * Can only insert DEFAULT into generated columns, regardless of
             * any OVERRIDING clauses.
             */
            if (att_tup->attgenerated && !apply_default)
}

I think the above comments are wrong, since there are no
OVERRIDING clauses for the generated column.



pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: bug in stored generated column over domain with constraints.
Next
From: Michael Paquier
Date:
Subject: Re: sync_standbys_defined read/write race on startup