Re: wrong comments in rewriteTargetListIU - Mailing list pgsql-hackers

Hi,

On Thu, Apr 10, 2025 at 5:58 PM jian he <jian.universality@gmail.com> wrote:
>
> hi.
>
> in function, rewriteTargetListIU
> we have:
>
> for (attrno = 1; attrno <= numattrs; attrno++)
> {
>             /*
>              * Can only insert DEFAULT into generated columns, regardless of
>              * any OVERRIDING clauses.
>              */
>             if (att_tup->attgenerated && !apply_default)
> }
>
> I think the above comments are wrong, since there are no
> OVERRIDING clauses for the generated column.

Hmm, I'm not sure that is quite right.  See 17958972fe3b which added
the comment, especially the test cases that it adds.

--
Thanks, Amit Langote