Postgres Pro
Downloads
Home   >   mailing lists

Re: custom function for converting human readable sizes to bytes - Mailing list pgsql-hackers

From Shulgin, Oleksandr
Subject Re: custom function for converting human readable sizes to bytes
Date
Msg-id CACACo5QrNisiLBG8kC_fAVdJ82sF7J4nxu+x8S2ZDRW94HdSqQ@mail.gmail.com
Whole thread Raw
In response to Re: custom function for converting human readable sizes to bytes  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: custom function for converting human readable sizes to bytes  (Pavel Stehule <pavel.stehule@gmail.com>)
Re: custom function for converting human readable sizes to bytes  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view
On Mon, Jan 4, 2016 at 4:51 PM, Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Jan 4, 2016 at 10:17 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
> [ new patch ]

+         case '-':
+             ereport(ERROR,
+                     (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
+                      errmsg("size cannot be negative")));

Why not?  I bet if you copy any - sign to the buffer, this will Just Work.

I'm also inclined on dropping that explicit check for empty string below and let numeric_in() error out on that.  Does this look OK, or can it confuse someone:

postgres=# select pg_size_bytes('');
ERROR:  invalid input syntax for type numeric: ""

?

+         if ( conv->base_unit == GUC_UNIT_KB &&

Between "(" and "conv->..." I believe.

---
Alex

pgsql-hackers by date:

Previous
From: "Shulgin, Oleksandr"
Date:
Subject: Re: pglogical - logical replication contrib module
Next
From: Pavel Stehule
Date:
Subject: Re: custom function for converting human readable sizes to bytes