Re: Anyone want to update our Windows timezone map? - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Anyone want to update our Windows timezone map?
Date
Msg-id CABUevEyRWqB6OCdsyhquuithHb+KS0OXwSCn+4HJHc-u3OyPpQ@mail.gmail.com
Whole thread Raw
In response to Re: Anyone want to update our Windows timezone map?  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Anyone want to update our Windows timezone map?  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Tue, Aug 16, 2016 at 11:15 AM, Michael Paquier <michael.paquier@gmail.com> wrote:
On Tue, Aug 16, 2016 at 9:14 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Tue, Aug 16, 2016 at 4:19 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> We have certainly not been doing that on a regular basis (as best I can
>> tell, no such changes have been made since 2010).  Does anybody who uses
>> Windows want to deal with it?  Or at least do it once so that our Windows
>> TZ info is less than 5 years out of date?
>
> It would be a good idea to refresh that.
>
>> If we got this done in the next couple weeks, any resulting changes
>> could go out in 9.6rc1.  Given that we've not done this routinely,
>> that seems like a better plan than having them first hit the field
>> in minor releases of stable branches.
>
> Agreed. I'll try to give it a shot in the next couple of days at worst.

I ran the script on my Win10 station, and saw the attached output,
which results in the patch attached once changes are applied. Results
can be visibly quite different depending on the station used though,
Win7 reports other things. Still my guess is that we'd want Win10 as a
base. Note as well that the registry has switched to UTC instead of
GMT. Thoughts?

I think what we want is basically the UNION ALL of all the different active versions. If we just use the definitions from Win10, we will map incorrectly on Win7. As long as they are not *conflicting*, we should just add them all.

The UTC->GMT switch is mostly just annoying as it only hits the comments, right? I think we just accept that change and do a once-over patch that changes all those things.


--

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: [PATCH] bigint txids vs 'xid' type, new txid_recent(bigint) => xid
Next
From: Magnus Hagander
Date:
Subject: Re: [RFC] Change the default of update_process_title to off