Re: pgsql: Fix union for pgstat message types - Mailing list pgsql-committers

From Magnus Hagander
Subject Re: pgsql: Fix union for pgstat message types
Date
Msg-id CABUevEwG_xigTB+7=EzM5o8EexxQ5_H-e5V9JFzD+aQ76NTsdA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fix union for pgstat message types  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix union for pgstat message types
List pgsql-committers
On Sat, May 4, 2019 at 5:54 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> On Wed, May 01, 2019 at 10:34:52AM +0000, Magnus Hagander wrote:
>> Fix union for pgstat message types

> Should the tempfile bit be backported? That message was added in 9.2.

It's just cosmetic I think.  The main point of having everything in
the union is to make sure the union's size/alignment are sufficient,
but the tempfile message isn't anywhere near creating an issue there.

That was my thought as well. It's really only needed when we add new things, to make sure we don't make those mistakes again. And nobody should be adding new pgstat messages in old branches. 

--

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Fix union for pgstat message types
Next
From: Peter Eisentraut
Date:
Subject: pgsql: pg_verify_checksums: Fix message punctuation