Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Failure in commit_ts tap tests - Mailing list pgsql-hackers

From Pavan Deolasee
Subject Re: [HACKERS] Failure in commit_ts tap tests
Date
Msg-id CABOikdPatXWB1y_-WvOA5Y1CbcT_SHstSQJoYDgK9+WXWK0TYw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Failure in commit_ts tap tests  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Failure in commit_ts tap tests
List pgsql-hackers
Tree view


On Sat, Jan 21, 2017 at 9:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:


Hm, but what of the "null" value?  Also, I get

$ perl -e 'use warnings; use Test::More; ok("2017-01-01" != "null", "ok");'
Argument "null" isn't numeric in numeric ne (!=) at -e line 1.
Argument "2017-01-01" isn't numeric in numeric ne (!=) at -e line 1.
ok 1 - ok

It declares the test as "passed", right? I am not saying that's a correct behaviour, but that's why we didn't catch the problem earlier. May be its a bug in the Test module?

If I add a non-numeric prefix to LHS string, test fails.

$ perl -e 'use warnings; use Test::More; ok("Fri 2017-46" != "null", "ok");'
Argument "null" isn't numeric in numeric ne (!=) at -e line 1.
Argument "Fri 2017-46" isn't numeric in numeric ne (!=) at -e line 1.
not ok 1 - ok
#   Failed test 'ok'
#   at -e line 1.
# Tests were run but no plan was declared and done_testing() was not seen.

Thanks,
Pavan

--
 Pavan Deolasee                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [HACKERS] Checksums by default?
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Failure in commit_ts tap tests