Re: [HACKERS] Failure in commit_ts tap tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Failure in commit_ts tap tests
Date
Msg-id 27447.1485014954@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Failure in commit_ts tap tests  (Pavan Deolasee <pavan.deolasee@gmail.com>)
Responses Re: [HACKERS] Failure in commit_ts tap tests  (Pavan Deolasee <pavan.deolasee@gmail.com>)
List pgsql-hackers
Pavan Deolasee <pavan.deolasee@gmail.com> writes:
> On Sat, Jan 21, 2017 at 9:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hm, but what of the "null" value?  Also, I get
>> 
>> $ perl -e 'use warnings; use Test::More; ok("2017-01-01" != "null", "ok");'
>> Argument "null" isn't numeric in numeric ne (!=) at -e line 1.
>> Argument "2017-01-01" isn't numeric in numeric ne (!=) at -e line 1.
>> ok 1 - ok

> It declares the test as "passed", right?

Oh!  So it does.  That is one darn weird behavior of the != operator.

> I am not saying that's a correct
> behaviour, but that's why we didn't catch the problem earlier.

Check.  Mystery solved.

There's still the point that we're not actually exercising this script
in the buildfarm ...
        regards, tom lane



pgsql-hackers by date:

Previous
From: Pavan Deolasee
Date:
Subject: Re: [HACKERS] Failure in commit_ts tap tests
Next
From: Stephen Frost
Date:
Subject: Re: [HACKERS] Checksums by default?