Re: Ignore invalid indexes in pg_dump - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Ignore invalid indexes in pg_dump
Date
Msg-id CAB7nPqTn660ArfDjpRpzhdoKdJke=+sZKJmUw8bQ6VKMdDheBg@mail.gmail.com
Whole thread Raw
In response to Re: Ignore invalid indexes in pg_dump  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On Wed, Mar 27, 2013 at 6:47 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Michael Paquier <michael.paquier@gmail.com> writes:
> On top of checking indisvalid, I think that some additional checks on
> indislive and indisready are also necessary.

Those are not necessary, as an index that is marked indisvalid should
certainly also have those flags set.  If it didn't require making two
new version distinctions in getIndexes(), I'd be okay with the extra
checks; but as-is I think the maintenance pain this would add greatly
outweighs any likely value.

I've committed this in the simpler form that just adds indisvalid
checks to the appropriate version cases.
Thanks.
--
Michael

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: spoonbill vs. -HEAD
Next
From: Jeff Davis
Date:
Subject: Re: regression test failed when enabling checksum