Re: Ignore invalid indexes in pg_dump - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Ignore invalid indexes in pg_dump
Date
Msg-id 21002.1364334450@sss.pgh.pa.us
Whole thread Raw
In response to Re: Ignore invalid indexes in pg_dump  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Ignore invalid indexes in pg_dump  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> On top of checking indisvalid, I think that some additional checks on
> indislive and indisready are also necessary.

Those are not necessary, as an index that is marked indisvalid should
certainly also have those flags set.  If it didn't require making two
new version distinctions in getIndexes(), I'd be okay with the extra
checks; but as-is I think the maintenance pain this would add greatly
outweighs any likely value.

I've committed this in the simpler form that just adds indisvalid
checks to the appropriate version cases.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: Drastic performance loss in assert-enabled build in HEAD
Next
From: Stefan Kaltenbrunner
Date:
Subject: Re: spoonbill vs. -HEAD