Re: Doing better at HINTing an appropriate column within errorMissingColumn() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Doing better at HINTing an appropriate column within errorMissingColumn()
Date
Msg-id CAB7nPqTR8tBtRnC_tW6z8Ya1tM9yCJfyTQad0Ko-cT7Lcp1+NQ@mail.gmail.com
Whole thread
In response to Re: Doing better at HINTing an appropriate column within errorMissingColumn()  (Peter Geoghegan <pg@heroku.com>)
Responses Re: Doing better at HINTing an appropriate column within errorMissingColumn()
List pgsql-hackers


On Mon, Nov 10, 2014 at 1:48 PM, Peter Geoghegan <pg@heroku.com> wrote:
On Fri, Nov 7, 2014 at 12:57 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> Based on this review from a month ago, I'm going to mark this Waiting
> on Author.  If nobody updates the patch in a few days, I'll mark it
> Returned with Feedback.  Thanks.

Attached revision fixes the compiler warning that Heikki complained
about. I maintain SQL-callable stub functions from within contrib,
rather than follow Michael's approach. In other words, very little has
changed from my revision from July last [1].
FWIW, I still find this bit of code that this patch adds in varlena.c ugly:
+#include "levenshtein.c"
+#define LEVENSHTEIN_LESS_EQUAL
+#include "levenshtein.c"
+#undef LEVENSHTEIN_LESS_EQUAL
--
Michael

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Doing better at HINTing an appropriate column within errorMissingColumn()
Next
From: Peter Geoghegan
Date:
Subject: Re: Doing better at HINTing an appropriate column within errorMissingColumn()