Re: Doing better at HINTing an appropriate column within errorMissingColumn() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Doing better at HINTing an appropriate column within errorMissingColumn()
Date
Msg-id CAB7nPqTR8tBtRnC_tW6z8Ya1tM9yCJfyTQad0Ko-cT7Lcp1+NQ@mail.gmail.com
Whole thread Raw
In response to Re: Doing better at HINTing an appropriate column within errorMissingColumn()  (Peter Geoghegan <pg@heroku.com>)
Responses Re: Doing better at HINTing an appropriate column within errorMissingColumn()  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
<div dir="ltr"><br /><div class="gmail_extra"><br /><div class="gmail_quote">On Mon, Nov 10, 2014 at 1:48 PM, Peter
Geoghegan<span dir="ltr"><<a href="mailto:pg@heroku.com" target="_blank">pg@heroku.com</a>></span> wrote:<br
/><blockquoteclass="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex"><spanclass="">On Fri, Nov 7, 2014 at 12:57 PM, Robert Haas <<a
href="mailto:robertmhaas@gmail.com">robertmhaas@gmail.com</a>>wrote:<br /> > Based on this review from a month
ago,I'm going to mark this Waiting<br /> > on Author.  If nobody updates the patch in a few days, I'll mark it<br />
>Returned with Feedback.  Thanks.<br /><br /></span>Attached revision fixes the compiler warning that Heikki
complained<br/> about. I maintain SQL-callable stub functions from within contrib,<br /> rather than follow Michael's
approach.In other words, very little has<br /> changed from my revision from July last [1].<span class=""><font
color="#888888"><br/></font></span></blockquote></div>FWIW, I still find this bit of code that this patch adds in
varlena.cugly:<br />+#include "levenshtein.c"<br />+#define LEVENSHTEIN_LESS_EQUAL<br />+#include "levenshtein.c"<br
/>+#undefLEVENSHTEIN_LESS_EQUAL<br /></div><div class="gmail_extra">-- <br /><div class="gmail_signature">Michael<br
/></div></div></div>

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Doing better at HINTing an appropriate column within errorMissingColumn()
Next
From: Peter Geoghegan
Date:
Subject: Re: Doing better at HINTing an appropriate column within errorMissingColumn()