Postgres Pro
Downloads
Home   >   mailing lists

Re: Doing better at HINTing an appropriate column within errorMissingColumn() - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Doing better at HINTing an appropriate column within errorMissingColumn()
Date
Msg-id CAM3SWZQQ5mi0mQeHs5e7TENFrC-pHP5CPm5HnZwqGQnvYz1Nig@mail.gmail.com
Whole thread Raw
In response to Re: Doing better at HINTing an appropriate column within errorMissingColumn()  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view 
On Sun, Nov 9, 2014 at 8:56 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> FWIW, I still find this bit of code that this patch adds in varlena.c ugly:
>
> +#include "levenshtein.c"
> +#define LEVENSHTEIN_LESS_EQUAL
> +#include "levenshtein.c"
> +#undef LEVENSHTEIN_LESS_EQUAL

Okay, but this is the coding that currently appears within contrib's
fuzzystrmatch.c, more or less unchanged. The "#undef
LEVENSHTEIN_LESS_EQUAL" line that I added ought to be unnecessary.
I'll give the final word on that to whoever picks this up.

-- 
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Doing better at HINTing an appropriate column within errorMissingColumn()
Next
From: Josh Berkus
Date:
Subject: Re: pg_multixact not getting truncated