Missing PG_INT32_MIN in numutils.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Missing PG_INT32_MIN in numutils.c
Date
Msg-id CAB7nPqTL0WFJ0b7xVHa5iPRWyNNJpFF1rr3gnY4sw1Jxabdt6g@mail.gmail.com
Whole thread Raw
Responses Re: Missing PG_INT32_MIN in numutils.c  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Hi all,

While going through numutils.c I found the following thing:
--- a/src/backend/utils/adt/numutils.c
+++ b/src/backend/utils/adt/numutils.c
@@ -136,7 +136,7 @@ pg_ltoa(int32 value, char *a)
     * Avoid problems with the most negative integer not being representable
     * as a positive integer.
     */
-   if (value == (-2147483647 - 1))
+   if (value == PG_INT32_MIN)
    {
        memcpy(a, "-2147483648", 12);
        return;
Attached is a patch. The interesting part is that pg_lltoa is not
missing the check on PG_INT64_MIN.
Regards,
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Optimization for updating foreign tables in Postgres FDW
Next
From: Michael Paquier
Date:
Subject: Re: [COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys.