Postgres Pro
Downloads
Home   >   mailing lists

Re: Verbose output of pg_dump not show schema name - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Verbose output of pg_dump not show schema name
Date
Msg-id CAB7nPqSHsP9oEXMSR0OHykr_X-RemyrBosifCz06bqYUcWQOJg@mail.gmail.com
Whole thread Raw
In response to Re: Verbose output of pg_dump not show schema name  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Responses Re: Verbose output of pg_dump not show schema name
Re: Verbose output of pg_dump not show schema name
List pgsql-hackers
Tree view 
On Tue, Aug 26, 2014 at 3:48 AM, Heikki Linnakangas
<hlinnakangas@vmware.com> wrote:
> AFAICS, the namespace can never be NULL in any of these. There is a
> "selectSourceSchema(fout, tbinfo->dobj.namespace->dobj.name)" call before or
> after printing the message, so if tbinfo->dobj.namespace is NULL, you'll
> crash anyway. Please double-check, and remove the dead code if you agree.
Ah right, this field is used in many places. Even for
pg_backup_archiver.c, the portion of code processing data always has
the namespace set. I am sure that Fabrizio would have done that
quickly, but as I was on this thread I simplified the patch as
attached.
Regards,
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Escaping from blocked send() reprised.
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Escaping from blocked send() reprised.