Re: Verbose output of pg_dump not show schema name - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Verbose output of pg_dump not show schema name
Date
Msg-id 53FC4B22.4070805@vmware.com
Whole thread Raw
In response to Re: Verbose output of pg_dump not show schema name  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 08/26/2014 10:10 AM, Michael Paquier wrote:
> On Tue, Aug 26, 2014 at 3:48 AM, Heikki Linnakangas
> <hlinnakangas@vmware.com> wrote:
>> AFAICS, the namespace can never be NULL in any of these. There is a
>> "selectSourceSchema(fout, tbinfo->dobj.namespace->dobj.name)" call before or
>> after printing the message, so if tbinfo->dobj.namespace is NULL, you'll
>> crash anyway. Please double-check, and remove the dead code if you agree.
> Ah right, this field is used in many places. Even for
> pg_backup_archiver.c, the portion of code processing data always has
> the namespace set. I am sure that Fabrizio would have done that
> quickly, but as I was on this thread I simplified the patch as

Ok thanks, committed.

- Heikki




pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: postgresql latency & bgwriter not doing its job
Next
From: Andres Freund
Date:
Subject: Re: postgresql latency & bgwriter not doing its job