Re: Verbose output of pg_dump not show schema name - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: Verbose output of pg_dump not show schema name
Date
Msg-id CAFcNs+oWm7tyaC7U9wbWCEKL+goOJfE+vuL9tZLc6QPMZ7s7Qg@mail.gmail.com
Whole thread Raw
In response to Re: Verbose output of pg_dump not show schema name  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
<div dir="ltr"><div class="gmail_extra"><br />On Tue, Aug 26, 2014 at 4:10 AM, Michael Paquier <<a
href="mailto:michael.paquier@gmail.com">michael.paquier@gmail.com</a>>wrote:<br />><br />> On Tue, Aug 26,
2014at 3:48 AM, Heikki Linnakangas<br /> > <<a
href="mailto:hlinnakangas@vmware.com">hlinnakangas@vmware.com</a>>wrote:<br />> > AFAICS, the namespace can
neverbe NULL in any of these. There is a<br />> > "selectSourceSchema(fout, tbinfo->dobj.namespace-><a
href="http://dobj.name">dobj.name</a>)"call before or<br /> > > after printing the message, so if
tbinfo->dobj.namespaceis NULL, you'll<br />> > crash anyway. Please double-check, and remove the dead code if
youagree.<br />> Ah right, this field is used in many places. Even for<br /> > pg_backup_archiver.c, the portion
ofcode processing data always has<br />> the namespace set. I am sure that Fabrizio would have done that<br />>
quickly,but as I was on this thread I simplified the patch as<br />> attached.<br /> ><br /><br /></div><div
class="gmail_extra">ThanksMichael... last night I was working on a refactoring in "tablecmds.c".<br /></div><div
class="gmail_extra"><br/></div><div class="gmail_extra">Regards,<br /><br /></div><div class="gmail_extra">--<br
/>Fabríziode Royes Mello<br />Consultoria/Coaching PostgreSQL<br />>> Timbira: <a
href="http://www.timbira.com.br">http://www.timbira.com.br</a><br/>>> Blog: <a
href="http://fabriziomello.github.io">http://fabriziomello.github.io</a><br/> >> Linkedin: <a
href="http://br.linkedin.com/in/fabriziomello">http://br.linkedin.com/in/fabriziomello</a><br/>>> Twitter: <a
href="http://twitter.com/fabriziomello">http://twitter.com/fabriziomello</a><br/>>> Github: <a
href="http://github.com/fabriziomello">http://github.com/fabriziomello</a></div></div>

pgsql-hackers by date:

Previous
From: Oskari Saarenmaa
Date:
Subject: Re: Switch pg_basebackup to use -X stream instead of -X fetch by default?
Next
From: Petr Jelinek
Date:
Subject: Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop]