Re: [HACKERS] A design for amcheck heapam verification - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] A design for amcheck heapam verification
Date
Msg-id CAB7nPqSBZJofXvhq1MsxZpmip2Z4qupsLr=HyDSup44XrN-3RQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] A design for amcheck heapam verification  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: [HACKERS] A design for amcheck heapam verification  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
On Wed, Nov 29, 2017 at 2:48 PM, Peter Geoghegan <pg@bowt.ie> wrote:
> I still don't think that regression tests as such make sense. However,
> it seems like it might be a good idea to add a test harness for the
> Bloom filter code. I actually wrote code like this for myself during
> development, that could be cleaned up. The hardness can live in
> source/src/test/modules/test_bloom_filter. We already do this for the
> red-black tree library code, for example, and it seems like good
> practice.
>
> Would that address your concern? There would be an SQL interface, but
> it would be trivial.

That's exactly what I think you should do, and mentioned so upthread.
A SQL interface can also show a good example of how developers can use
this API.
-- 
Michael


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Function to move the position of a replication slot
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] A design for amcheck heapam verification