recovery_min_apply_delay with a negative value - Mailing list pgsql-hackers

From Michael Paquier
Subject recovery_min_apply_delay with a negative value
Date
Msg-id CAB7nPqS6yQEFC1=4yR_d8yQ4rEw4+ZBhjB4nvHC_av2wLnayVg@mail.gmail.com
Whole thread Raw
Responses Re: recovery_min_apply_delay with a negative value  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
List pgsql-hackers
Hi all,

While reviewing another patch, I have noticed that recovery_min_apply_delay can have a negative value. And the funny part is that we actually attempt to apply a delay even in this case, per se this condition recoveryApplyDelay@xlog.c:
        /* nothing to do if no delay configured */
        if (recovery_min_apply_delay == 0)
                return false;
Shouldn't we simply leave if recovery_min_apply_delay is lower 0, and not only equal to 0?
Regards,
--
Michael

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: attaching a process in eclipse
Next
From: Michael Paquier
Date:
Subject: Re: Patch: add recovery_timeout option to control timeout of restore_command nonzero status code