Re: recovery_min_apply_delay with a negative value - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: recovery_min_apply_delay with a negative value
Date
Msg-id CAFcNs+q9qU+tip8E3f4hBpT1HtUuCvx5Mf2a_w8YSVKXCiVpAw@mail.gmail.com
Whole thread Raw
In response to recovery_min_apply_delay with a negative value  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: recovery_min_apply_delay with a negative value  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers


On Sun, Dec 28, 2014 at 12:31 PM, Michael Paquier <michael.paquier@gmail.com> wrote:
>
> Hi all,
>
> While reviewing another patch, I have noticed that recovery_min_apply_delay can have a negative value. And the funny part is that we actually attempt to apply a delay even in this case, per se this condition recoveryApplyDelay@xlog.c:
>         /* nothing to do if no delay configured */
>         if (recovery_min_apply_delay == 0)
>                 return false;
> Shouldn't we simply leave if recovery_min_apply_delay is lower 0, and not only equal to 0?
>

Seems reasonable.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [GENERAL] ON_ERROR_ROLLBACK
Next
From: Merlin Moncure
Date:
Subject: Re: BUG #12330: ACID is broken for unique constraints