Re: request patch pg_recvlogical.c, pg_receivexlog.c for nls - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: request patch pg_recvlogical.c, pg_receivexlog.c for nls
Date
Msg-id CAB7nPqR-Atxm_QkX0kX5Og0HQ5wg4-vXpFUDtGZU1Pka9oiG3Q@mail.gmail.com
Whole thread Raw
In response to request patch pg_recvlogical.c, pg_receivexlog.c for nls  (Ioseph Kim <pgsql-kr@postgresql.kr>)
Responses Re: request patch pg_recvlogical.c, pg_receivexlog.c for nls  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Mon, Dec 28, 2015 at 5:07 PM, Ioseph Kim <pgsql-kr@postgresql.kr> wrote:
> Hello,
>
> at PostgreSQL version 9.5rc1,
> at line 934 in pg_recvlogical.c
>
>         set_pglocale_pgservice(argv[0],PG_TEXTDOMAIN("pg_recvlogical"));
>
> this references invalid catalog file, because pg_basebackup,
> pg_recvlogical, pg_receivexlog commands use same catalog file
> pg_basebackup.mo
>
> pg_receivexlog.c too.
>
> patch please.

Yes, you are right. Both values do not match CATALOG_NAME in nls.mk. I
guess that something like the attached is fine then... The other
binaries are fine.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: pg_upgrade tests running calling psql without --no-psqlrc
Next
From: Alvaro Herrera
Date:
Subject: Re: request patch pg_recvlogical.c, pg_receivexlog.c for nls