Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path - Mailing list pgsql-hackers

From David Rowley
Subject Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path
Date
Msg-id CAApHDvp9uxVqOPk6KadZV0Od2GNzem447MYuxbZOLUNFmdAy5Q@mail.gmail.com
Whole thread Raw
In response to Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On Wed, 25 Nov 2020 at 04:48, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
>
> On 2020-11-24 01:52, Dagfinn Ilmari Mannsåker wrote:
> > The Clang documentation¹ suggest an even neater solution, which would
> > eliminate the repetitive empty pg_attribute_foo #defines in the trailing
> > #else/#endif block in commit 1fa22a43a56e1fe44c7bb3a3d5ef31be5bcac41d:
> >
> > #ifndef __has_attribute
> > #define __has_attribute(x) 0
> > #endif
>
> Yes, this was also mentioned and agreed earlier in the thread, but then
> we apparently forgot to update the patch.

I wanted to let the buildfarm settle a bit before changing this again.
I plan on making the change today.

(I know walleye is still not happy)

David



pgsql-hackers by date:

Previous
From: Anastasia Lubennikova
Date:
Subject: Ready For Committer patches (CF 2020-11)
Next
From: Robert Haas
Date:
Subject: Re: bug in pageinspect's "tuple data" feature