Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path
Date
Msg-id c4171207-43ca-548d-7d45-53358f95ca91@2ndquadrant.com
Whole thread Raw
In response to Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Responses Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On 2020-11-24 01:52, Dagfinn Ilmari Mannsåker wrote:
> The Clang documentation¹ suggest an even neater solution, which would
> eliminate the repetitive empty pg_attribute_foo #defines in the trailing
> #else/#endif block in commit 1fa22a43a56e1fe44c7bb3a3d5ef31be5bcac41d:
> 
> #ifndef __has_attribute
> #define __has_attribute(x) 0
> #endif

Yes, this was also mentioned and agreed earlier in the thread, but then 
we apparently forgot to update the patch.

-- 
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/



pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Custom compression methods
Next
From: "David G. Johnston"
Date:
Subject: Re: abstract Unix-domain sockets