Re: Is tuplesort meant to support bounded datum sorts? - Mailing list pgsql-hackers

From David Rowley
Subject Re: Is tuplesort meant to support bounded datum sorts?
Date
Msg-id CAApHDvo0Z=EMi=xmEf7e0mtcQr_pAjn7V99+ANH=d2_7=xXbEA@mail.gmail.com
Whole thread Raw
In response to Re: Is tuplesort meant to support bounded datum sorts?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, 13 Jul 2021 at 04:10, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > It looks like this has likely never come up before because the only
> > time we use tuplesort_set_bound() is in nodeSort.c and
> > nodeIncrementalSort.c, none of those currently use datum sorts.
> > However, I'm thinking this is still a bug that should be fixed
> > separately from Ronan's main patch.
>
> Yeah, I think you're right.  The comment seems a little confused
> though.  Maybe there's no need for it at all --- there's equivalent
> code in e.g. writetup_datum that has no comment.

Thanks for looking at this.  I've pushed a fix and backpatched.

David



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: O_DIRECT on macOS
Next
From: Michael Paquier
Date:
Subject: Re: Introduce pg_receivewal gzip compression tests