Re: Is tuplesort meant to support bounded datum sorts? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Is tuplesort meant to support bounded datum sorts?
Date
Msg-id 2981082.1626106224@sss.pgh.pa.us
Whole thread Raw
In response to Is tuplesort meant to support bounded datum sorts?  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Is tuplesort meant to support bounded datum sorts?  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> It looks like this has likely never come up before because the only
> time we use tuplesort_set_bound() is in nodeSort.c and
> nodeIncrementalSort.c, none of those currently use datum sorts.
> However, I'm thinking this is still a bug that should be fixed
> separately from Ronan's main patch.

Yeah, I think you're right.  The comment seems a little confused
though.  Maybe there's no need for it at all --- there's equivalent
code in e.g. writetup_datum that has no comment.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Use WaitLatch for {pre, post}_auth_delay instead of pg_usleep
Next
From: vignesh C
Date:
Subject: Re: proposal - psql - use pager for \watch command