Re: O_DIRECT on macOS - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: O_DIRECT on macOS
Date
Msg-id CA+hUKGLYTWZ7=y=p=VqwOjqyTnCMa4g46DxkX73Qiuc0U8R3EQ@mail.gmail.com
Whole thread Raw
In response to Re: O_DIRECT on macOS  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: O_DIRECT on macOS  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Mon, May 31, 2021 at 10:29 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> For comparison, here is my sketch of idea #1.  I pick an arbitrary
> value to use as PG_O_DIRECT (I don't want to define O_DIRECT for fear
> of breaking other code that might see it and try to pass it into
> open()... for all I know, it might happen to match OS-internal value
> O_NASAL_DEMONS), and statically assert that it doesn't collide with
> standard flags we're using, and I strip it out of the flags I pass in
> to open().  As I said, a bit icky, but it's a tiny and localised
> patch, which is nice.

I'm planning to go with that idea (#1), if there are no objections.



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Fix comments of heap_prune_chain()
Next
From: David Rowley
Date:
Subject: Re: Is tuplesort meant to support bounded datum sorts?