Possible typo/unclear comment in joinpath.c - Mailing list pgsql-hackers

From James Coleman
Subject Possible typo/unclear comment in joinpath.c
Date
Msg-id CAAaqYe8fxZjq3na+XkNx4C78gDqykH-7dbnzygm9Qa9nuDTePg@mail.gmail.com
Whole thread Raw
Responses Re: Possible typo/unclear comment in joinpath.c  (Justin Pryzby <pryzby@telsasoft.com>)
List pgsql-hackers
In joinpath.c three times we reference "extra_lateral_rels" (with
underscores like it's a field), but as far as I can tell that's not a
field anywhere in the source code, and looking at the code that
follows it seems like it should be referencing "lateral_relids" (and
the "extra" is really "extra [in relation to relids]").

Assuming that interpretation is correct, I'd attached a patch to
change all three occurrences to "extra lateral_relids" to reduce
confusion.

Thanks,
James

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Converting contrib SQL functions to new style
Next
From: David Christensen
Date:
Subject: [PATCH] expand the units that pg_size_pretty supports on output