Re: Possible typo/unclear comment in joinpath.c - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: Possible typo/unclear comment in joinpath.c
Date
Msg-id 20210414164253.GI6091@telsasoft.com
Whole thread Raw
In response to Possible typo/unclear comment in joinpath.c  (James Coleman <jtc331@gmail.com>)
Responses Re: Possible typo/unclear comment in joinpath.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Apr 14, 2021 at 11:36:38AM -0400, James Coleman wrote:
> In joinpath.c three times we reference "extra_lateral_rels" (with
> underscores like it's a field), but as far as I can tell that's not a
> field anywhere in the source code, and looking at the code that
> follows it seems like it should be referencing "lateral_relids" (and
> the "extra" is really "extra [in relation to relids]").

It looks like a loose end from 

commit edca44b1525b3d591263d032dc4fe500ea771e0e
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date:   Mon Dec 7 18:56:14 2015 -0500

    Simplify LATERAL-related calculations within add_paths_to_joinrel().

-- 
Justin



pgsql-hackers by date:

Previous
From: Honza Horak
Date:
Subject: Options given both on cmd-line and in the config with different values
Next
From: Alexander Korotkov
Date:
Subject: Re: jsonb subscripting assignment performance