Re: Few observations in replication slots related code - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Few observations in replication slots related code
Date
Msg-id CAA4eK1K2DJ+Yd2mGvH5JF4vXpMTE906LT2Gk=2y9ggsV3d21Ng@mail.gmail.com
Whole thread Raw
In response to Re: Few observations in replication slots related code  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On Thu, Jun 12, 2014 at 5:02 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> On 2014-06-12 09:15:08 +0200, Andres Freund wrote:
> > > 6.
> > > elog(ERROR, "cannot handle changeset extraction yet");
> > >
> > > Shouldn't it be better to use logical replication instead
> > > of changeset extraction?
> >
> > Will change.
>
> I don't see that message anywhere in current code? 

Right, actually I was reading code from Git History and also
referring latest code, so it seems I have seen that in original
commit and missed to verify it in latest code.

While checking latest code, I got usage of *changeset extraction*
in below comment:

/*

..

*

 * This is useful to initialize the cutoff xid after which a new changeset

 * extraction replication slot can start decoding changes.

 *

..

*/

  

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: postgresql.auto.conf read from wrong directory
Next
From: Tom Lane
Date:
Subject: Re: lo_create(oid, bytea) breaks every extant release of libpq