Re: [HACKERS] Function to move the position of a replication slot - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: [HACKERS] Function to move the position of a replication slot
Date
Msg-id CA+q6zcVCO=9MC5VyukG5b=Eh3gi61VUqifZjW7=T7X+6aVV1Vw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Function to move the position of a replication slot  (Craig Ringer <craig@2ndquadrant.com>)
Responses Re: [HACKERS] Function to move the position of a replication slot  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
List pgsql-hackers
> On 4 May 2017 at 20:05, Magnus Hagander <magnus@hagander.net> wrote:
>
> PFA a patch that adds a new function, pg_move_replication_slot, that makes it
> possible to move the location of a replication slot without actually
> consuming all the WAL on it.
 
Just a few questions just a few questions out of curiosity:

* does it make sense to create a few tests for this function in
  `contrib/test_decoding` (as shown in attachment)?

* what should happen if the second argument is `NULL`? There is a verification
  `XLogRecPtrIsInvalid(moveto)`, but it's possible to pass `NULL`, and looks
  like it leads to result different from boolean:

```
SELECT pg_move_replication_slot('regression_slot_5', NULL);
 pg_move_replication_slot
--------------------------
 
(1 row)
```
Attachment

pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands
Next
From: "Sven R. Kunze"
Date:
Subject: Re: [HACKERS] Adding support for Default partition in partitioning