> On 4 May 2017 at 20:05, Magnus Hagander <magnus@hagander.net> wrote: > > PFA a patch that adds a new function, pg_move_replication_slot, that makes it > possible to move the location of a replication slot without actually > consuming all the WAL on it.
Just a few questions just a few questions out of curiosity:
* does it make sense to create a few tests for this function in `contrib/test_decoding` (as shown in attachment)?
* what should happen if the second argument is `NULL`? There is a verification `XLogRecPtrIsInvalid(moveto)`, but it's possible to pass `NULL`, and looks like it leads to result different from boolean: