Re: On non-Windows, hard depend on uselocale(3) - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: On non-Windows, hard depend on uselocale(3)
Date
Msg-id CA+hUKGL9aZ4mn0OMR-D=5+qpdxOsO_tGyOQhK2nW1raTemAFAQ@mail.gmail.com
Whole thread Raw
In response to Re: On non-Windows, hard depend on uselocale(3)  ("Tristan Partin" <tristan@partin.io>)
List pgsql-hackers
On Wed, Aug 14, 2024 at 11:17 AM Tristan Partin <tristan@partin.io> wrote:
> Thanks for picking this up. I think your patch looks really good.

Thanks for looking!

> Are
> you familiar with gcc's function poisoning?
>
>         #include <stdio.h>
>         #pragma GCC poison puts
>
>         int main(){
>         #pragma GCC bless begin puts
>             puts("a");
>         #pragma GCC bless end puts
>         }
>
> I wonder if we could use function poisoning to our advantage. For
> instance in ecpg, it looks like you got all of the strtod() invocations
> and replaced them with strtod_l(). Here is a patch with an example of
> what I'm talking about.

Thanks, this looks very useful.



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Remaining dependency on setlocale()
Next
From: Ilia Evdokimov
Date:
Subject: Re: Vacuum statistics